Add event version column#2321
Merged
Merged
Conversation
ejsmith
commented
Jun 25, 2026
ejsmith
force-pushed
the
feature/add-event-version-column
branch
from
c51faa9 to
f612ef6
Compare
ejsmith
commented
Jun 27, 2026
ejsmith
left a comment
ejsmith
left a comment
Member
Author
There was a problem hiding this comment.
I found one blocker.
- The new
versiontable column can be enabled in the UI, but saved-view validation still rejects it. Save/update sends the currentcolumnsandcolumn_orderto the saved-view endpoints, andNewSavedView.ValidColumnIdsdoes not includeversionforeventsorstream, so a user who enables or orders this column will get a 422 when saving/updating the view. Addversionto the event and stream allow-lists and cover it in the saved-view validation tests. - CI note: the current
test-apifailure is from the branch being behindmain; the failing paging tests are covered byFix event cursor pagination links (#2322). Rebase/mergemainand rerun checks after the allow-list fix.
Member
Author
|
Addressed the remaining review feedback in c098626:
Local verification: Current GitHub checks for c098626 are still running: |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
versionto event summary responses from the existing event@versionmetadata.Versioncolumn to the Svelte event table so it can be selected and saved in saved views.Closes #1299.
Verification
npm run checkinsrc/Exceptionless.Web/ClientAppdotnet test tests/Exceptionless.Tests/Exceptionless.Tests.csproj -- --filter-class Exceptionless.Tests.Plugins.SummaryDataTests